Skip to content

fix(ux): propagate swallowed errors in workspace resolution#131

Merged
skevetter merged 2 commits into
mainfrom
fix/swallowed-errors
Apr 25, 2026
Merged

fix(ux): propagate swallowed errors in workspace resolution#131
skevetter merged 2 commits into
mainfrom
fix/swallowed-errors

Conversation

@skevetter

Copy link
Copy Markdown
Contributor

Summary

  • resolveWorkspace was discarding findWorkspace errors with _, causing misleading "workspace doesn't exist" messages when the real error was a network failure, permission denied, etc. Now propagates the actual error.
  • Promotes workdir resolution error logging in resolveMergedWorkspaceFolder from Debug to Warn so users have visibility when workspace result loading fails.
  • findLocalWorkspace error swallowing was already addressed by PR fix(workspace): propagate findWorkspace errors and fix list append bug #124 (which fixed the parent findWorkspace function to propagate List() errors).

resolveWorkspace was discarding findWorkspace errors with _, causing
misleading "doesn't exist" messages when the real error was a network
failure or permission denied. Also promotes workdir resolution error
logging from Debug to Warn for user visibility.
Two additional log.Debugf calls in pkg/loftconfig/config.go used %w,
which produces garbled output in log functions.
@netlify

netlify Bot commented Apr 25, 2026

Copy link
Copy Markdown

Deploy Preview for devsydev canceled.

Name Link
🔨 Latest commit a130cd3
🔍 Latest deploy log https://app.netlify.com/projects/devsydev/deploys/69ed165970035500088b6c56

@coderabbitai

coderabbitai Bot commented Apr 25, 2026

Copy link
Copy Markdown

Warning

Rate limit exceeded

@skevetter has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 38 minutes and 2 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 38 minutes and 2 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 6cf9238a-505f-4562-9243-04047bf7739b

📥 Commits

Reviewing files that changed from the base of the PR and between 42418d1 and a130cd3.

📒 Files selected for processing (3)
  • cmd/ssh.go
  • pkg/loftconfig/config.go
  • pkg/workspace/workspace.go

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@skevetter
skevetter merged commit 41d7d38 into main Apr 25, 2026
47 checks passed
@skevetter
skevetter deleted the fix/swallowed-errors branch April 25, 2026 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant